Enable CI/clang-tidy #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
force-pushed
the
master
branch
3 times, most recently
from
b95e694 to
f5c9ae6
Compare
vgvassilev
force-pushed
the
ci-salva
branch
2 times, most recently
from
4e74fdb to
4d1f1c5
Compare
…ture paper including forces and diffusion modules
Co-authored-by: Vassil Vassilev <[email protected]>
Co-authored-by: Vassil Vassilev <[email protected]>
* all work I have done untill the midterm: tumor replicated from the nature paper including forces and diffusion modules * car-t oxygen consumption * Update README.md Co-authored-by: Vassil Vassilev <[email protected]> * Update src/cart_cell.cc Co-authored-by: Vassil Vassilev <[email protected]> * still in progress CAR-T displacement * cleaned comments to follow Doxygen-style * changed comments to follow doxygen-style * Remove draft_code_my_own_analysis/ from tracking and add to .gitignore * remove draft_code_my_own_analysis * add to gitignore draft_code_my_own_analysis * fixing comments * [ci] Add basic github actions infrastructure * Update CMakeLists.txt Co-authored-by: Vassil Vassilev <[email protected]> * Update README.md Co-authored-by: Vassil Vassilev <[email protected]> * Update README.md Co-authored-by: Vassil Vassilev <[email protected]> * Update src/cart_cell.cc use *Simulation::GetActive()->GetResourceManager() just once Co-authored-by: Vassil Vassilev <[email protected]> * Update src/cart_cell.cc Co-authored-by: Vassil Vassilev <[email protected]> * Update src/forces_tumor_cart.cc Co-authored-by: Vassil Vassilev <[email protected]> * changed some things to imporve code quality * cart_cell comments fixed * changed all comments to /// in the .h and changed some of them * changed the project name + new readme part Results * minor change spelling * 30-days simulation --------- Co-authored-by: Vassil Vassilev <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| InteractionForce* InteractionVelocity::NewCopy() const { | ||
| return std::make_unique<InteractionVelocity>().release(); |
There was a problem hiding this comment.
warning: no header providing "std::make_unique" is directly included [misc-include-cleaner]
src/forces_tumor_cart.cc:23:
+ #include <memory>| */ | ||
|
|
||
| #ifndef TUMOR_HYPERPARAMS_H_ | ||
| #define TUMOR_HYPERPARAMS_H_ |
There was a problem hiding this comment.
warning: header guard does not follow preferred style [llvm-header-guard]
Suggested change
| #define TUMOR_HYPERPARAMS_H_ | |
| #ifndef GITHUB_WORKSPACE_SRC_HYPERPARAMS_H | |
| #define GITHUB_WORKSPACE_SRC_HYPERPARAMS_H |
src/hyperparams.h:244:
+ endif // GITHUB_WORKSPACE_SRC_HYPERPARAMS_H
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.